Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add preparation_state to feedback email #2079

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

MoritzWeber0
Copy link
Member

The preparation state was not part of the email, only the state.

Copy link

The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification.
Please run make openapi locally and commit the changes.

Copy link

github-actions bot commented Dec 10, 2024

API Changelog 4.15.1.dev12+g022d22fe

POST /api/v1/feedback

  • ⚠️ request property 'sessions/items/state' was restricted to a list of enum values
  • added the new optional request property 'sessions/items/preparation_state'
  • added the new 'Failed' enum value to the request property 'sessions/items/state'
  • added the new 'NotFound' enum value to the request property 'sessions/items/state'
  • added the new 'Pending' enum value to the request property 'sessions/items/state'
  • added the new 'Running' enum value to the request property 'sessions/items/state'
  • added the new 'Terminated' enum value to the request property 'sessions/items/state'
  • added the new 'Unknown' enum value to the request property 'sessions/items/state'

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 requested a review from zusorio December 11, 2024 08:28
The preparation state was not part of the email, only the state.
@MoritzWeber0 MoritzWeber0 force-pushed the preparation-state-feedback branch from bc20960 to a81095f Compare December 11, 2024 09:10
Copy link

sonarcloud bot commented Dec 11, 2024

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.50%. Comparing base (d4de17f) to head (a81095f).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2079   +/-   ##
=======================================
  Coverage   85.50%   85.50%           
=======================================
  Files         224      224           
  Lines        7431     7432    +1     
  Branches      520      520           
=======================================
+ Hits         6354     6355    +1     
  Misses        911      911           
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

A Storybook preview is available for commit 022d22f.
➡️ View Storybook
➡️ View Chromatic build

Copy link

This report was generated by comparing 022d22f with d4de17f.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 432
change 0
new 0
delete 0

@MoritzWeber0 MoritzWeber0 merged commit ebe2c33 into main Dec 11, 2024
32 checks passed
@MoritzWeber0 MoritzWeber0 deleted the preparation-state-feedback branch December 11, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants